-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow color specification in non-RGB formats #301
Comments
Hi @sea-bass I did some search and my suggestion is to use Let me know your thoughts. If this approach makes sense, I would like to contribute to this issue. I tested my suggestion using the Code Changes:
Results |
That looks great @kumar-sanjeeev -- just note that the paths to/from world files specified in YAML also need to be proven out. There are lots of tests that should help with that though! |
Okay, understood. I just need one clarification: From what I understand, I need to change any [R, G, B] color values used in source code and YAML files with matplotlib color functionality, while keeping the values the same or similar. Is that correct? If I’m missing something, please let me know. |
Yeah, probably just if statements on whether the value is a list of numbers or a string... |
Okay, cool. I will start implementing with the colors already mentioned in the codebase and YAML files. Later, if needed, we can also add other available color values that users can choose from to describe colors. For example, the following base colors.
|
The suggestion was "Would be nice to be able to specify colors as strings supporting standard color strings like "red" or "#0F0F0F""
There are probably some standard modules that can take care of this already, so it's a matter of searching.
The text was updated successfully, but these errors were encountered: