Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove common prefixes and suffixes from actual and expected single-line strings #117

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Oct 29, 2024

closes #116

@staabm staabm force-pushed the short-diff branch 5 times, most recently from d135d92 to 8c462d7 Compare October 29, 2024 18:30
@staabm staabm marked this pull request as ready for review October 29, 2024 18:31
@staabm
Copy link
Contributor Author

staabm commented Oct 29, 2024

//cc @Schrank

@staabm
Copy link
Contributor Author

staabm commented Oct 29, 2024

should be good to go

@staabm
Copy link
Contributor Author

staabm commented Oct 30, 2024

hopefully this will fix this build :)

@sebastianbergmann
Copy link
Owner

AFAICS, the build failed due to GitHub Actions' outage.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (5ef523a) to head (ee79ea0).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #117      +/-   ##
============================================
+ Coverage     98.91%   99.00%   +0.08%     
- Complexity      127      140      +13     
============================================
  Files            15       15              
  Lines           370      400      +30     
============================================
+ Hits            366      396      +30     
  Misses            4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@staabm
Copy link
Contributor Author

staabm commented Oct 30, 2024

I saw errors regarding test executed code it should not cover

@staabm
Copy link
Contributor Author

staabm commented Oct 30, 2024

Grreeeeen :-)

@sebastianbergmann
Copy link
Owner

Looking at the changes, I only see removeOverlongCommonPrefix() and findCommonPrefix(), but not similar methods for suffixes. Are common suffixes handled or not? Sorry, cannot look at it more closely just now.

@staabm
Copy link
Contributor Author

staabm commented Oct 30, 2024

you are right. I totally forgot about the suffixes. added them now.

@sebastianbergmann sebastianbergmann merged commit 8c4071f into sebastianbergmann:main Oct 30, 2024
8 checks passed
@staabm staabm deleted the short-diff branch October 30, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove common prefixes and suffixes from actual and expected single-line strings
2 participants