Feature/Selective mocking #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal for issue lomsa-com#136.
This package has two ways of mocking for Dio:
DioInterceptorDioAdapterIt is my understanding that selective mocking only works for the first one as the latter one completely exchanges the
HttpClientAdapterof Dio.My proposed solution is to add a boolean
failOnMissingMock, which is by defaulttruefor backwards compatibility. If set tofalsewe do not throw an exception anymore when a mock is not matched, but instead send back aFuture.value(null). This way we can detect the mismatch in theDioInterceptorand letDiocall the next interceptor.Also, I added an option to print basic logs which are by default turned off.
@LukaGiorgadze what do you think?