fixes tcl-core [1f40aa83c552f597]: suppress integer-overflow trapping…

… (atm, GCC "trapv" only) for intended pieces, avoid unexpected app-crash; back-ported from tcl-core
sebres · Mar 15, 2024 · a1788d5 · a1788d5
1 parent 42649e0
commit a1788d5
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/generic/tclClockFmt.c b/generic/tclClockFmt.c
@@ -56,6 +56,11 @@ static void ClockFrmScnFinalize(ClientData clientData);
  *----------------------------------------------------------------------
  */
 
+/* int overflows may happens here (expected case) */
+#if defined(__GNUC__) || defined(__GNUG__)
+# pragma GCC optimize("no-trapv")
+#endif
+
 static inline int
 _str2int(
     int	       *out,
@@ -115,6 +120,10 @@ _str2wideInt(
     *out = val;
     return TCL_OK;
 }
+
+#if defined(__GNUC__) || defined(__GNUG__)
+# pragma GCC reset_options
+#endif
 
 /*
  *----------------------------------------------------------------------

diff --git a/generic/tclDate.c b/generic/tclDate.c
@@ -2676,6 +2676,11 @@ LookupWord(
     return tID;
 }
 
+/* int overflows may happens here (expected case) */
+#if defined(__GNUC__) || defined(__GNUG__)
+# pragma GCC optimize("no-trapv")
+#endif
+
 static int
 TclDatelex(
     YYSTYPE* yylvalPtr,
@@ -2813,6 +2818,10 @@ TclDatelex(
 	} while (Count > 0);
     }
 }
+
+#if defined(__GNUC__) || defined(__GNUG__)
+# pragma GCC reset_options
+#endif
 
 int
 TclClockFreeScan(

diff --git a/generic/tclGetDate.y b/generic/tclGetDate.y
@@ -877,6 +877,11 @@ LookupWord(
     return tID;
 }
 
+/* int overflows may happens here (expected case) */
+#if defined(__GNUC__) || defined(__GNUG__)
+# pragma GCC optimize("no-trapv")
+#endif
+
 static int
 TclDatelex(
     YYSTYPE* yylvalPtr,
@@ -1014,6 +1019,10 @@ TclDatelex(
 	} while (Count > 0);
     }
 }
+
+#if defined(__GNUC__) || defined(__GNUG__)
+# pragma GCC reset_options
+#endif
 
 int
 TclClockFreeScan(