Added RuleBase class to allow easier use of the library #75
Conversation
| return this.rules[i].result; | ||
| } | ||
| // If no rule evaluated to true then there is a problem with the model. | ||
| return(-1); |
| * initialized to "false". | ||
| */ | ||
| addRule(evaluator, result) { | ||
| this.rules.push( { evaluator: evaluator, evaluation: false, result: result} ); |
There was a problem hiding this comment.
will a max value for rules be useful here? just to make sure no one is creating something uncomputable
| * was evaluated to true. | ||
| */ | ||
| getResult(){ | ||
| for(let i = 0; i < this.rules.length; i++){ |
There was a problem hiding this comment.
maybe a question of style: amaybe consider using .map, filter and a length check
Additionally this makes it possible to only return something from one line.
| * It looks for the rule (should be only one if the model is correct) that | ||
| * was evaluated to true. | ||
| */ | ||
| getResult(){ |
There was a problem hiding this comment.
naming: getResult .. tehse days I try not to write get ... there are actually getters for that ...
There was a problem hiding this comment.
ok I'll modify the name, maybe to evaluation()
| @@ -1,6 +1,6 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright (c) 2015 [these people](https://github.com/sebs/es6-fuzz/graphs/contributors) | |||
| Copyright (c) 2015 [these people](https://github.com/skanderturki/js-fuzzy-logic/graphs/contributors) | |||
There was a problem hiding this comment.
I think the link in my repo represents very well who contributed.
There was a problem hiding this comment.
ok, I'm not used to this, thanks
| @@ -1,4 +1,4 @@ | |||
| # es6-fuzz | |||
| # js-fuzzy-logic ( forked from: es6-fuzz ) | |||
There was a problem hiding this comment.
this one needs to be the old value to be merged.
| @@ -21,12 +21,6 @@ Supported fuzzyfiers | |||
| * [api docs](http://sebs.github.io/es6-fuzz) | |||
| * [changelog](https://github.com/sebs/es6-fuzz/blob/master/docs/CHANGELOG.md) | |||
|
|
|||
| ## Install and Usage | |||
| @@ -0,0 +1,70 @@ | |||
| const Logic = require('./lib/logic') | |||
There was a problem hiding this comment.
please move this to examples folder,
|
I am happy to merge as soon as the the comments are addressed. I think its mostly cosmetics. Thank you for the time! |
Hi seb,
I have added the class (RuleBase) along with an example that illustrates how to use the class. I hope you find this useful.
Thanks