-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task 87 #28
Task 87 #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! This is quite complex to specify. One thing that the prompt doesn't specify at all, but that a user of this code might expect, would be that the entries in coords
are distinct. This is already implied by the combination of row_sorted_asc
and row_col_sorted_desc
(and the fact that the later uses strict inequality), so you could leave that implicit or you could write a (hopefully short) lemma showing that's the case.
tasks/human_eval_087.rs
Outdated
} | ||
|
||
/// Returns lst as a Seq. | ||
pub open spec fn lst_seq_refl(lst: Vec<Vec<i32>>) -> Seq<Seq<i32>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't very discoverable at the moment, unfortunately, but I think this function is equivalent to doing lst.deep_view()
. Looking at the source for the DeepView trait shows more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If changing to deep_view
breaks a bunch of proofs, it's probably not worth changing at this point. Just a note for the future.
Very nice! Sorry, I didn't realize you had pushed changes since I reviewed the initial PR. I'll merge this in. |
No description provided.