Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace recursion of Repeat::parse_helper with a loop #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhengyao-lin
Copy link
Member

I noticed that the original parse_help still gets compiled to a recursive function. So I replaced it with a loop instead. No particular performance impact though.

@y1ca1
Copy link
Collaborator

y1ca1 commented Dec 20, 2024

  1. Does it make sense to remove the parse_helper entirely?
  2. For consistency, do we want serialize to be a loop as well?

@zhengyao-lin
Copy link
Member Author

  1. Yeah probably;
  2. Makes sense; will get to that at some point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants