Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Tag Generation #79

Merged

Conversation

Robert-MacWha
Copy link
Contributor

Frameworks PR Checklist

Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:

  • Describe your changes, substitute this text with the information
  • If you are touching an existing piece of content, ask the original creator for review
  • If you need feedback for your content from wider community, share the PR in our Discord
  • Review changes to ensure there are no typos, see instructions below

Summary
Updated the tag generation script to (a) use sha1 hashing instead of the tag's length in determining colour, and (b) allow for user-specified tag colours.

(a): Given that lots of tags will likely share the same length, it would be unfortunate for them all to share the same colour.

(b): I wanted a SEAL tag to use SEAL blue (#4339db)

@tebayoso: this seems to be your code, so requesting review.

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frameworks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 8:31pm

@mattaereal
Copy link
Collaborator

This was a feature request I asked for, so thanks for being proactive about it and pushing it forward!

@Robert-MacWha
Copy link
Contributor Author

This was a feature request I asked for, so thanks for being proactive about it and pushing it forward!

I did not realize that lol. Was there an issue for that request I should link? #68 perhaps?

If you liked this, you'll love #80

@mattaereal
Copy link
Collaborator

I don't see issues, so I'm merging this. If @tebayoso sees something's amiss we can always fix it in a future PR

@mattaereal mattaereal merged commit 4961e9e into security-alliance:develop Oct 9, 2024
3 of 4 checks passed
@Robert-MacWha Robert-MacWha deleted the develop-tags-update branch October 9, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants