Youtube premieres identified by isLive videoDetails json key #715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes lavaplayer to play YouTube Premiere videos correctly - currently the video begins playing (at the active premiere timestamp) then stops after a few seconds, instead of playing to the end.
YouTube Premieres are basically "pre-recorded livestreams" -- channels upload a video, then start an automated livestream that plays it back with all the usual livestream features (chat, etc.). Lavaplayer should treat these as livestreams in order to play them correctly, but Premieres show the pre-recorded video length which confuses lavaplayer into thinking it's a normal video.
A (possibly new?) videoDetails json key
isLive
is available to tell if a video is a currently-streaming livestream or Premiere. This PR updates lavaplayer to use that field to identify content that should be streamed.Further bug details:
"isLiveContent": false, "lengthSeconds": <length>
"isLiveContent": true, "isLive": true, "lengthSeconds": 0
"isLiveContent": true, "lengthSeconds": <length>
"isLiveContent": false, "isLive": true, "lengthSeconds": <length>
"isLiveContent": false, "lengthSeconds": <length>