Skip to content
This repository has been archived by the owner on Jan 2, 2025. It is now read-only.

Commit

Permalink
frontend: restrict desktop tests to frontend changes
Browse files Browse the repository at this point in the history
  • Loading branch information
horacioh committed Jan 8, 2024
1 parent 6dae2d4 commit 5c6dab4
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 8 deletions.
11 changes: 9 additions & 2 deletions .github/workflows/test-desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,16 @@ permissions:

on:
push:
branches: [e2e]
branches: [main, e2e]
paths:
- frontend/*
- ".github/workflows/test-desktop.yml"

pull_request:
branches: [e2e]
branches: [main, e2e]
paths:
- frontend/*
- ".github/workflows/test-desktop.yml"

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
14 changes: 8 additions & 6 deletions frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,15 @@ test('Onboarding from scratch', async ({onboardingPage}) => {
})

await test.step('Wallet', async () => {
// let elWalletBtn = await appWindow.locator('#btn-accept-wallet')
let elWalletBtn = await appWindow.locator('#btn-accept-wallet')
let elNextBtn = await appWindow.locator('#btn-next')
// await elWalletBtn.click()
// let elWalletSuccessMssg = await appWindow.getByText(
// 'Your wallet is ready to use!',
// )
// await expect(elWalletSuccessMssg).toBeVisible()
// we need to give the backend some warm-up time for this to work.
await appWindow.waitForTimeout(6000)
await elWalletBtn.click()
let elWalletSuccessMssg = await appWindow.getByText(
'Your wallet is ready to use!',
)
await expect(elWalletSuccessMssg).toBeVisible()

Check failure on line 48 in frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts

View workflow job for this annotation

GitHub Actions / Test on macos-latest-xl @ x64

[e2e] › onboarding-from-scratch.e2e.ts:5:5 › Onboarding from scratch

1) [e2e] › onboarding-from-scratch.e2e.ts:5:5 › Onboarding from scratch › Wallet ───────────────── Error: expect(locator).toBeVisible() Locator: getByText('Your wallet is ready to use!') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 30000ms - waiting for getByText('Your wallet is ready to use!') 46 | 'Your wallet is ready to use!', 47 | ) > 48 | await expect(elWalletSuccessMssg).toBeVisible() | ^ 49 | expect(elNextBtn).toBeInViewport() 50 | await elNextBtn.click() 51 | }) at /Users/runner/work/mintter/mintter/frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts:48:39 at /Users/runner/work/mintter/mintter/frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts:39:3

Check failure on line 48 in frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts

View workflow job for this annotation

GitHub Actions / Test on macos-latest-xl @ x64

[e2e] › onboarding-from-scratch.e2e.ts:5:5 › Onboarding from scratch

1) [e2e] › onboarding-from-scratch.e2e.ts:5:5 › Onboarding from scratch › Wallet ───────────────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: expect(locator).toBeVisible() Locator: getByText('Your wallet is ready to use!') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 30000ms - waiting for getByText('Your wallet is ready to use!') 46 | 'Your wallet is ready to use!', 47 | ) > 48 | await expect(elWalletSuccessMssg).toBeVisible() | ^ 49 | expect(elNextBtn).toBeInViewport() 50 | await elNextBtn.click() 51 | }) at /Users/runner/work/mintter/mintter/frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts:48:39 at /Users/runner/work/mintter/mintter/frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts:39:3

Check failure on line 48 in frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts

View workflow job for this annotation

GitHub Actions / Test on macos-latest-xl @ x64

[e2e] › onboarding-from-scratch.e2e.ts:5:5 › Onboarding from scratch

1) [e2e] › onboarding-from-scratch.e2e.ts:5:5 › Onboarding from scratch › Wallet ───────────────── Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: expect(locator).toBeVisible() Locator: getByText('Your wallet is ready to use!') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 30000ms - waiting for getByText('Your wallet is ready to use!') 46 | 'Your wallet is ready to use!', 47 | ) > 48 | await expect(elWalletSuccessMssg).toBeVisible() | ^ 49 | expect(elNextBtn).toBeInViewport() 50 | await elNextBtn.click() 51 | }) at /Users/runner/work/mintter/mintter/frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts:48:39 at /Users/runner/work/mintter/mintter/frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts:39:3
expect(elNextBtn).toBeInViewport()
await elNextBtn.click()
})
Expand Down

0 comments on commit 5c6dab4

Please sign in to comment.