This repository has been archived by the owner on Jan 2, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New dev setup and testing for the Desktop app
new location of appData in dev mode:
new env variables set
new dev scripts:
run-desktop-mainnet
: runs the desktop app in dev mode pointing to mainnet (runs this internally: MINTTER_P2P_TESTNET_NAME='' yarn desktop
)test-desktop
: builds and run the tests for the desktop appnew yarn scrips:
desktop:test
: the script./dev test-desktop
will rundesktop:test:package
: only package the app for testing (with separate env variables from prod and dev)test
: package and run teststest:only
: only run tests. this needs the app to be built so make sure you build it firste2e
: runs the playwright scripte2e:debug
: runs the playwright script withPWDEBUG=1
e2e:report
: show the already generated playwright reports if anyIf you want to run a second device of the app, you need to override the next env varaibles:
this variables follow a pattern: the ports follow the
5500x
pattern, in dev5600x
and in test5800x
feel free to change it for a new device:when running both apps at the same time, the first app running will show a blank screen bc you are rebuilding the frontend files again. just need to reload the affected version of the app and you are good to go.
Testing
Now every push and PR to main will run a new Github Action:
test-desktop
. this action will build the app (in MacOS only for now) and run all the tests.the guide to create tests will be in a Mintter publication. Also a more detailed explanation about all this.
ping @horacioh for any questions!