-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export config with standard format #19
Conversation
Imho, the duplicate rules should be separated to another PR. |
@ruimarinho needs rebase. |
Why are you calling this a preset? Since we are dropping |
@@ -1,21 +0,0 @@ | |||
The MIT License (MIT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason for removing this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unnecessary. The license fields on the package manifest accepts any SPDX identifier, so "MIT" is enough there.
02e31f6
to
10b2c1d
Compare
@ruiquelhas rebased. |
Regarding src/index, the idea is to open the door to future presets, such as backend/frontend/es2015/es2016, but I'm fine with removing |
I just think we should stick to what is recommended by If the "standard" changes in the future, we can adapt accordingly. |
10b2c1d
to
9e71022
Compare
Works for me. PR updated. |
I would probably change the PR name for the sake of clarity. Not sure exactly what to call it though. |
Do you have any suggestion or can this be merged? |
Export config with standard format
babel/generator-star-spacing
rule to use "before" spacing instead of "after" (probably wasn't working at all?).Might help with #13 and #18 too.
Closes #2.