Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export config with standard format #19

Merged
merged 1 commit into from
Feb 3, 2016

Conversation

ruimarinho
Copy link
Contributor

  • Removed babel as only tests could potentially benefit from transpiling.
  • Cleaned up tests.
  • Tidied up package.json.
  • Fixed babel/generator-star-spacing rule to use "before" spacing instead of "after" (probably wasn't working at all?).

Might help with #13 and #18 too.

Closes #2.

@nunofgs
Copy link
Contributor

nunofgs commented Jan 12, 2016

Imho, the duplicate rules should be separated to another PR.

@ruiquelhas
Copy link
Contributor

@ruimarinho needs rebase.

@ruiquelhas
Copy link
Contributor

Why are you calling this a preset? Since we are dropping babel, I would suggest we use src/index.js for the config itself as described here instead of using a specific json file. That seems to be the most common format out there.

@@ -1,21 +0,0 @@
The MIT License (MIT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason for removing this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unnecessary. The license fields on the package manifest accepts any SPDX identifier, so "MIT" is enough there.

@ruimarinho ruimarinho force-pushed the enhancement/export-as-preset branch from 02e31f6 to 10b2c1d Compare January 13, 2016 23:12
@ruimarinho
Copy link
Contributor Author

@ruiquelhas rebased.

@ruimarinho
Copy link
Contributor Author

Regarding src/index, the idea is to open the door to future presets, such as backend/frontend/es2015/es2016, but I'm fine with removing presets/seegno.json and inline it in src/index.js.

@ruimarinho
Copy link
Contributor Author

@ruiquelhas
Copy link
Contributor

I just think we should stick to what is recommended by eslint. So, I would prefer to continue calling it config (there is no mention of preset anywhere in the docs) and keep it in the index.js file (avoiding premature optimization).

If the "standard" changes in the future, we can adapt accordingly.

@ruimarinho ruimarinho force-pushed the enhancement/export-as-preset branch from 10b2c1d to 9e71022 Compare January 25, 2016 22:26
@ruimarinho
Copy link
Contributor Author

Works for me. PR updated.

@ruiquelhas
Copy link
Contributor

I would probably change the PR name for the sake of clarity. Not sure exactly what to call it though.

@ruimarinho
Copy link
Contributor Author

Do you have any suggestion or can this be merged?

@ruiquelhas ruiquelhas changed the title Export as preset instead of plugin Export config with standard format Feb 3, 2016
ruiquelhas added a commit that referenced this pull request Feb 3, 2016
@ruiquelhas ruiquelhas merged commit 3fcc906 into master Feb 3, 2016
@ruiquelhas ruiquelhas deleted the enhancement/export-as-preset branch February 3, 2016 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants