Component support for datasets #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added to TimeSeries as well, with a default value of 1. This should be backwards compatible with any existing code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First in a long list of branches that have been in-flight for a year.
Adds support for volumes that have multiple components (i.e. contain vector data). The number of components is specified in the config file with
"components": <int>, which defaults to 1 if not included. When aDataFile'snumComponents> 1, the vector data is converted to scalar by computing the vector magnitude. After reading, the data layout is identical to volumes with scalar data to begin with.Works for memory-mapped and non-memory-mapped binary files, but does not work for NetCDF files. NetCDF support is tenuous at best and so needs a lot of attention on its own.