Skip to content
This repository has been archived by the owner on Feb 28, 2018. It is now read-only.

Allow direct import without using a fully-qualified name #46

Merged
merged 1 commit into from
Oct 15, 2016
Merged

Allow direct import without using a fully-qualified name #46

merged 1 commit into from
Oct 15, 2016

Conversation

billmei
Copy link

@billmei billmei commented Oct 14, 2016

All credit goes to @ahoym for discovering and fixing this, as well as for the following problem description:

Files that used the react-ux-password-field had to directly grab the component from the lib/react-ux-password-field.js file since otherwise their tests would unexpectedly fail.

This meant imports had to be written like:

import InputPassword from 'react-ux-password-field/lib/react-ux-password-field';

After the change in 57816ba, we no longer need to do this and can:

import InputPassword from 'react-ux-password-field';

@billmei billmei changed the base branch from v1.0 to upstream October 14, 2016 22:40
@billmei billmei changed the base branch from upstream to v1.0 October 14, 2016 22:40
@seethroughdev
Copy link
Owner

Thanks for the PR. Happy to merge this, but please note, I'm unable to maintain this project.

See: #44

It also includes a new fork that is maintained. Although I haven't used it, I'd definitely recommend checking it out:

https://github.com/mmw/react-password-strength

@seethroughdev seethroughdev merged commit 4f13724 into seethroughdev:v1.0 Oct 15, 2016
@billmei billmei deleted the kortaggio/point-main-field-to-lib branch October 15, 2016 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants