-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONFIG-325] Increase ldb download speeds #117
Open
zhou-hongyu
wants to merge
27
commits into
master
Choose a base branch
from
hzhou/CONFIG-325-increase-ldb-download-speeds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
45f09ac
[CF-111] add wal monitor to export sqlite metrics
wavetylor 84245c4
[CF-111] add rows metric for by prefix scan
wavetylor a3f6589
[CF-111] add metric for time downloading ldb file
wavetylor 2a037ab
revert to go 1.13 functions
wavetylor 9158a14
use make vendor in github workflow
wavetylor f52d049
Use go '1.20' not go 1.2
wavetylor cc96cb9
improve documentation, naming and add configuration option for disab…
wavetylor 7f80d6e
upgrade docker to go 1.20
wavetylor 98e8af4
revert to go 1.13
wavetylor 697d4ae
Revert to go 1.20, close query
wavetylor e9cbd43
wip
f3e229d
WIP
c0b727e
WIP
caa8463
fix test
fbdf101
use klauspost/pgzip
7a6b747
replace awserr with smithy-go
09f57d6
revert changes by mistake
7506380
revert replacing awserr with smithy-go
714dcea
Update pkg/reflector/download_test.go
zhou-hongyu 26f03e2
fix test
8f520fc
reverted unwanted changes
467fb2e
free ourselves of all aws-sdk-go v1
50a2cc4
log s3 client's downloading time
36dba8f
Bootstrap LDB regardless of existence
70ac14e
remove leading slash
54251d8
remove leading slash
0df2e02
more concurrency
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we free ourselves of all aws-sdk-go v1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried getting rid of
awserrlib but there is really no equivalence in sdk v2, the most closed one would besmithy-go, but that would still require us making some minor logic changes in the testing file. I can definitely give it another try and you can take a lookThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so I freed reflector pkg from v1, but I then realized that there are much more places using v1, e.g., ledger_monitor which uses ecs client. I don't think it's gonna be a trivia task to completely free this repo from v1, would you think that's acceptable?