Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to go-based SQLite driver (cvd) #129

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erikdw
Copy link
Collaborator

@erikdw erikdw commented Oct 27, 2023

Note
This is a resurrection of Collin Van Dyck's attempt to do this:

See Colin King's version here: #128


Better benchmarks
Break out executive tests into their own funcs.
Having a single func that runs the other tests is too laborious when you only want to run a small handful of tests. Remove errors dependencies.
Tidy
Fix errors.Cause
Remove unused test fn
Fix errors.Wrap issue
Simple test failure
Fix usage of errors.Wrap


Warning
For this PR to be viable, we'll need to either:

  • fix that by adding connect hooks with the Go-based sqlite driver somehow -OR-
  • change the build & module import setup to somehow support using the Go-based driver for the library we produce, but the CGO-based library for the ctlstore-reflector and other ctlstore daemons.

Better benchmarks
Break out executive tests into their own funcs.
Having a single func that runs the other tests is too laborious when you only want to run a small handful of tests.
Remove errors dependencies.
Tidy
Fix errors.Cause
Remove unused test fn
Fix errors.Wrap issue
Simple test failure
Fix usage of errors.Wrap
@erikdw erikdw changed the title switch to go-based SQLite driver switch to go-based SQLite driver (collin) Oct 27, 2023
@erikdw erikdw changed the title switch to go-based SQLite driver (collin) switch to go-based SQLite driver (cvd) Oct 27, 2023
@erikdw erikdw added the Don't Merge This is only for performance testing and to resolve OOM issue for consent feature in warehouses label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Don't Merge This is only for performance testing and to resolve OOM issue for consent feature in warehouses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant