Skip to content

Commit

Permalink
Bump ui-box from 5.4.0 to 5.4.1 to fix primary link Tab (#1626)
Browse files Browse the repository at this point in the history
Co-authored-by: Dan <[email protected]>
  • Loading branch information
brandongregoryscott and dlasky authored May 5, 2023
1 parent 135bbd6 commit 25ec16d
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 12 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"prop-types": "^15.6.2",
"react-fast-compare": "^3.2.0",
"react-transition-group": "^4.4.1",
"ui-box": "^5.4.0"
"ui-box": "^5.4.1"
},
"peerDependencies": {
"react": "^16.8.0 || ^17.0.0 || ^18.0.0",
Expand Down
17 changes: 10 additions & 7 deletions src/tabs/stories/index.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ class TabManager extends React.PureComponent {
}
}

const appearances = ['primary', 'secondary']
const tabs = ['Traits', 'Event History', 'Identities']

storiesOf('tabs', module).add('Tab', () => (
Expand Down Expand Up @@ -99,13 +100,15 @@ storiesOf('tabs', module).add('Tab', () => (
</StoryHeader>

<Box>
<TabNavigation marginX={-4} marginBottom={16}>
{tabs.map((tab, index) => (
<Tab key={tab} is="a" href="#" id={tab} isSelected={index === 0}>
{tab}
</Tab>
))}
</TabNavigation>
{appearances.map(appearance => (
<TabNavigation key={appearance} marginX={-4} marginBottom={16}>
{tabs.map((tab, index) => (
<Tab key={tab} appearance={appearance} is="a" href="#" id={tab} isSelected={index === 0}>
{tab}
</Tab>
))}
</TabNavigation>
))}
</Box>
</StorySection>
<StorySection>
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -14414,10 +14414,10 @@ [email protected]:
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.4.tgz#a2a3d2756c079abda241d75f149df9d561091e78"
integrity sha512-Uz+dTXYzxXXbsFpM86Wh3dKCxrQqUcVMxwU54orwlJjOpO3ao8L7j5lH+dWfTwgCwIuM9GQ2kvVotzYJMXTBZg==

ui-box@^5.4.0:
version "5.4.0"
resolved "https://registry.yarnpkg.com/ui-box/-/ui-box-5.4.0.tgz#707c764fdf4be79cf2f50f356ca9583a491164ee"
integrity sha512-HuiJKUIOGW/I1VF7EgHl5/3OwywPdV5fwzsDOWfCGS/PORmXOyGetL3gJo9EQJZZZCkui9xf3a/UQhawA88yeQ==
ui-box@^5.4.1:
version "5.4.1"
resolved "https://registry.yarnpkg.com/ui-box/-/ui-box-5.4.1.tgz#34f497a143783a3513e850bd58379ac583e3f2fb"
integrity sha512-5p+b6kSh1q/bptvLANuAusyB/3fGIvnw8w6rSZNPHckQ8UdPfjIK4DvinmMXRKgdniOba22h8ypVqtkJ9zK/iQ==
dependencies:
"@emotion/hash" "^0.7.1"
inline-style-prefixer "^5.0.4"
Expand Down

0 comments on commit 25ec16d

Please sign in to comment.