-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query owner on ERC-721 and ERC-1155 pointers #2043
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to add migration handler to update existing deployed pointers to use this new code?
The CW1155 contract follows the same ownership pattern as CW721s. We should add that functionality into the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2043 +/- ##
==========================================
+ Coverage 61.16% 61.27% +0.10%
==========================================
Files 264 264
Lines 24566 24569 +3
==========================================
+ Hits 15026 15054 +28
+ Misses 8415 8386 -29
- Partials 1125 1129 +4
|
@@ -270,7 +277,7 @@ func (am AppModule) ExportGenesisStream(ctx sdk.Context, cdc codec.JSONCodec) <- | |||
} | |||
|
|||
// ConsensusVersion implements ConsensusVersion. | |||
func (AppModule) ConsensusVersion() uint64 { return 16 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was previously off by one
Describe your changes and provide context
Add an
owner()
function that adheres to the Ownable interface. Note: we are only adding the ability to query the owner, not the ability to change the owner. CW721_ownable has the concept of the new owner accepting the new ownership for the ownership transfer to go through which ERC Ownable does not have which makes it tricky to do the write functions of actually updating ownership.Testing performed to validate your change
integration test