Skip to content
This repository has been archived by the owner on Dec 12, 2021. It is now read-only.

Test enhancement #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peter279k
Copy link

@peter279k peter279k commented Jul 29, 2019

Changed log

  • Add the .phpunit.result.cache in .gitignore because cached unit test result file should not be under the Git version control.
  • Add EOF(end of file) for every file.
  • Change the namespace to TwigTests and using TwigTest class for TwigTest.php file because of consistency.
  • Add the autoload-dev block to define test class namespaces and this will be load the test classes automatically.
  • Upgrade the PHPUnit to 8.x version because this view package requires php-7.2 at least now.
  • The assertStringContains will be deprecated warning message since using the PHPUnit 8.
    Using the assertStringContains instead.
  • The epxectedException comment annotation is deprecated since using the PHPUnit 8.
    Using the expectException method instead.
  • To be compatible with TestCase::setUp method, it should be protected function setUp(): void.

References

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant