Fix example capture.py
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symptom was: > # python3 ./examples/capture.py output.txt asciinema rec -c 'timeout 3 htop' output.cast > Traceback (most recent call last): > File "[..]/examples/capture.py", line 39, in <module> > data = os.read(master_fd, 1024) > OSError: [Errno 5] Input/output error > > # python3 --version > Python 3.10.13
hartwork
force-pushed
the
examples-fix-capture-py
branch
from
30ae02d
to
17d4324
Compare
.. to reduce nesting to simplify the structure.
Symptom was: > # python3 ./examples/capture.py output.txt asciinema rec -c 'timeout 3 htop' output.cast > Traceback (most recent call last): > File "/usr/lib/python-exec/python3.10/asciinema", line 8, in <module> > sys.exit(main()) > File "/usr/lib/python3.10/site-packages/asciinema/__main__.py", line 61, in main > cfg = config.load() > File "/usr/lib/python3.10/site-packages/asciinema/config.py", line 226, in load > config = Config(get_config_home(env), env) > File "/usr/lib/python3.10/site-packages/asciinema/config.py", line 216, in get_config_home > raise Exception( > Exception: need $HOME or $XDG_CONFIG_HOME or $ASCIINEMA_CONFIG_HOME
hartwork
force-pushed
the
examples-fix-capture-py
branch
from
17d4324
to
58d2189
Compare
|
@selectel I believe this is ready for merge now. What do you think? |
1 similar comment
|
@selectel I believe this is ready for merge now. What do you think? |
|
Thanks, Sebastian. @selectel does not maintain this repo, sadly. It's just me checking in once in a while. |
|
@superbobry thanks for the merge! Has it been considered to move/transfer the repository to your account? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for
examples/capture.py! 🙏While playing with it I discovered three key issues about it and felt like offering a pull request with fixes to give back. These issues were:
OSErrorHOMEAs a bonus I resolved a needless
elseto reduce nesting and make the structure a bit simpler. Review on commit level is probably most efficient.What do you think?