Address devices marked as multiple types #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases (e.g. iPad using Chrome mobile) where a device ends up being marked as both tablet and mobile. The commit gives priority to explicit device family over determining it from browser family. selwin#107
...even when requesting a desktop version of page. See: https://docs.aws.amazon.com/silk/latest/developerguide/user-agent.html selwin#107
BorePlusPlus
changed the title
BorePlusPlus
force-pushed
the
exclusive
branch
from
9d95e7f to
fa966e9
Compare
Irrespective of the browser it is running
and not PCs
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases (e.g. iPad using Chrome mobile) where a device ends up
being marked as both tablet and mobile.
The PR gives priority to explicit device family over determining it by other means.
#107