Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/Group implementation #2

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Feat/Group implementation #2

merged 1 commit into from
Feb 12, 2025

Conversation

KimiWu123
Copy link
Collaborator

@KimiWu123 KimiWu123 commented Feb 7, 2025 •
edited
Loading

Description

This PR implemented Group functions. LeanIMT uses Vivian's implementation.

Related Issue(s)

To close #3

Checklist

  • I have read and understand the contributor guidelines and code of conduct.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@KimiWu123 KimiWu123 marked this pull request as ready for review February 7, 2025 07:33
@KimiWu123 KimiWu123 removed the request for review from vivianjeng February 7, 2025 07:33
@KimiWu123 KimiWu123 changed the title init: copied from Kimi's repo Feat/Group implementation Feb 7, 2025
@KimiWu123 KimiWu123 self-assigned this Feb 7, 2025
@KimiWu123 KimiWu123 added the feature 🚀 This is enhancing something existing or creating something new label Feb 7, 2025
@KimiWu123
Copy link
Collaborator Author

@vplasencia this PR is ready for review!

@vplasencia
Copy link
Member

Great work with this PR @KimiWu123 🚀

@vplasencia vplasencia merged commit 3f6bf63 into main Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplasencia vplasencia vplasencia approved these changes

Assignees

@KimiWu123 KimiWu123

Labels
feature 🚀 This is enhancing something existing or creating something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group implementation
2 participants
@KimiWu123 @vplasencia