Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github workflows need to be revisited #808

Open
cedoor opened this issue Jun 26, 2024 · 3 comments
Open

Github workflows need to be revisited #808

cedoor opened this issue Jun 26, 2024 · 3 comments
Assignees
Labels
devops 🔧 Operations management and dev tools

Comments

@cedoor
Copy link
Member

cedoor commented Jun 26, 2024

Description

Semaphore's Github pull_requests workflow has recently been optimized to run some jobs only when related files are actually changed (#765). However, the file and folder paths to be considered for detecting changes do not take into account some configuration files, thus preventing some jobs from running even when they should.

Additionally, recently ZK-Kit has further optimized the workflows:

  • merging the pull_requests and production workflows into 1: main
  • sharing cached dependencies among jobs

Semaphore workflows therefore need to be updated with the above points in mind. This issue is supposed to be used to discuss these points and converge on a final solution to be adopted.

@cedoor cedoor added the devops 🔧 Operations management and dev tools label Jun 26, 2024
@cedoor cedoor moved this to 🗒 Tasks in Semaphore Board Jun 26, 2024
@cedoor cedoor self-assigned this Jun 26, 2024
@cedoor
Copy link
Member Author

cedoor commented Jul 8, 2024

@sripwoud looks like there are other issues with the workflows after this PR: #810.

There are some warnings while building the libraries, and some untracked files are generated in the CLI templates.

@sripwoud
Copy link
Contributor

sripwoud commented Jul 8, 2024

which workflow/jobs exactly? There are quite a bunch ^^

@cedoor
Copy link
Member Author

cedoor commented Jul 8, 2024

which workflow/jobs exactly? There are quite a bunch ^^

Sorry, it's not directly related to the workflow. You can try yourself by just running yarn build after cloning the repo. It looks like the --topological-dev option doesn't work well.

@cedoor cedoor moved this from 🗒 Tasks to 🏗 In Progress in Semaphore Board Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops 🔧 Operations management and dev tools
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

3 participants