[Security] Added edge cases for tainted pickle deserialization #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xDC0DE
approved these changes
Oct 15, 2024
|
Looks like a good update to me! Thanks for your contribution! |
0xDC0DE
requested changes
Oct 15, 2024
Comment on lines
+45
to
+52
| # ruleid: tainted-pickle-deserialization | ||
| pickle.load(pickle.dumps(event['exploit_code'])) | ||
|
|
||
| # ruleid: tainted-pickle-deserialization | ||
| _pickle.loads(_pickle.dumps(event['exploit_code'])) | ||
|
|
||
| # ruleid: tainted-pickle-deserialization | ||
| cPickle.load(cPickle.dumps(event['exploit_code'])) |
There was a problem hiding this comment.
Looks like these are incorrectly annotated. If I understand correctly, you don't want these to match. This should be fixed before we can merge these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pattern-notconditions to exclude safe usage patterns and minimize false positives.The patterns like
pickle.load(pickle.dumps(...))are added topattern-notto avoid false positives in situations where the data being deserialized is explicitly serialized using pickle.dumps() within the same codebase.