Cover all SQS addMessages conditions with tests

Some addMessages conditions weren't tested which reduced the unit tests code coverage.
semji · Jan 26, 2016 · a9914db · a9914db
1 parent 09e53ab
commit a9914db
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/tests/units/Adapter/NullAdapter.php b/tests/units/Adapter/NullAdapter.php
@@ -13,6 +13,12 @@ public function testNullAdapterAddMessage()
         $this->given($NullAdapter)->class($NullAdapter->addMessage('testQueue', 'test Message one'))->hasInterface('\ReputationVIP\QueueClient\Adapter\AdapterInterface');
     }
 
+    public function testNullAdapterAddMessages()
+    {
+        $NullAdapter = new \ReputationVIP\QueueClient\Adapter\NullAdapter();
+        $this->given($NullAdapter)->class($NullAdapter->addMessages('testQueue', ['test Message one']))->hasInterface('\ReputationVIP\QueueClient\Adapter\AdapterInterface');
+    }
+
     public function testNullAdapterGetMessages()
     {
         $NullAdapter = new \ReputationVIP\QueueClient\Adapter\NullAdapter();

diff --git a/tests/units/Adapter/SQSAdapter.php b/tests/units/Adapter/SQSAdapter.php
@@ -62,7 +62,31 @@ public function testSQSAdapterAddMessages()
         $mockSqsClient->getMockController()->sendMessageBatch = function () {
         };
         $this->given($SQSAdapter)
-            ->class($SQSAdapter->addMessages('testQueue', ['test message', 'test message 2']))->hasInterface('\ReputationVIP\QueueClient\Adapter\AdapterInterface');
+            ->class($SQSAdapter->addMessages('testQueue', array_fill(0, 11, 'test message')))->hasInterface('\ReputationVIP\QueueClient\Adapter\AdapterInterface');
+    }
+
+    public function testSQSAdapterAddMessagesWithEmptyMessage()
+    {
+        $this->mockGenerator->orphanize('__construct');
+        $this->mockGenerator->shuntParentClassCalls();
+        $mockSqsClient = new \mock\Aws\Sqs\SqsClient;
+        $SQSAdapter = new \ReputationVIP\QueueClient\Adapter\SQSAdapter($mockSqsClient);
+
+        $this->exception(function() use($SQSAdapter) {
+            $SQSAdapter->addMessages('testQueue', ['test message', '']);
+        });
+    }
+
+    public function testSQSAdapterAddMessagesWithEmptyQueueName()
+    {
+        $this->mockGenerator->orphanize('__construct');
+        $this->mockGenerator->shuntParentClassCalls();
+        $mockSqsClient = new \mock\Aws\Sqs\SqsClient;
+        $SQSAdapter = new \ReputationVIP\QueueClient\Adapter\SQSAdapter($mockSqsClient);
+
+        $this->exception(function() use($SQSAdapter) {
+            $SQSAdapter->addMessages('', ['']);
+        });
     }
 
     public function testSQSAdapterGetMessagesWithEmptyQueueName()