Skip to content

Commit

Permalink
revert: bundle @sendbird/chat as peer dependency (#320)
Browse files Browse the repository at this point in the history
Even though it is more desirable,
Adding `@sendbird/chat` as peer dependency fails the bundled library 
Need to investigate more
  • Loading branch information
sravan-s authored Sep 27, 2022
1 parent f987980 commit 71d3605
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
"author": "SendBird <[email protected]>",
"license": "SEE LICENSE IN LICENSE.md",
"peerDependencies": {
"@sendbird/chat": "^4.0.11",
"css-vars-ponyfill": "^2.3.2",
"date-fns": "^2.16.1",
"prop-types": "^15.7.2",
Expand Down
3 changes: 2 additions & 1 deletion rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ module.exports = ({
},
],
external: [
'@sendbird/chat',
// unbundled version of @sendbird/chat fails in production
// '@sendbird/chat',
'react-dom/server',
'prop-types',
'react',
Expand Down
3 changes: 1 addition & 2 deletions scripts/package.template.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@
"date-fns": "^2.16.1",
"prop-types": "^15.7.2",
"react": "^16.8.6 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.8.6 || ^17.0.0 || ^18.0.0",
"@sendbird/chat": "^4.0.11"
"react-dom": "^16.8.6 || ^17.0.0 || ^18.0.0"
},
"dependencies": {
"@sendbird/chat": "^4.0.11",
Expand Down

0 comments on commit 71d3605

Please sign in to comment.