Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes: * Donot bundle chat sdk with uikit compiled code Compiled UIKit code that is distributed through npm shouldnt have Chat SDK minified code included in it Chat SDK should be a dependency of UIKit Advantages: * Chat SDK bug fixes will be added for free * Eliminate the need for handlers What caused the issue: If you are usig rollup for bundling in config.external you have to be specific ie> This works: ``` external: [ '@sendbird/chat', '@sendbird/chat/groupChannel', '@sendbird/chat/openChannel', '@sendbird/chat/message', ] ``` This doesnt: ``` external: [ '@sendbird/chat', ] ``` * Only react and react-dom should be peerDependencies For npm >= v7, npm autoinstall peerDependency packages According to https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependencies You want to express the compatibility of your package with a host tool or library while not necessarily doing a require of this host Even though react is required, its better to show that react is the host tool
- Loading branch information