Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: comment on PR workflow #315

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

zevisert
Copy link
Contributor

Follow up from #312. Starting with a simpler, but insecure (vulnerable to github secret exfiltration via "pwn requests"). I can implement the more secure, but more complicated workflow incase there's secrets (for some reason) in this repo that need protection.

@zevisert
Copy link
Contributor Author

This has to be committed to main before the latter part (commenting on the PR) will run.

@zevisert
Copy link
Contributor Author

There's two broken links, but I want to leave them so that (hopefully) we can see the whole pipeline working in a followup MR. Once this is merge, I'll come back to remove those 404's

@demoore demoore merged commit 8cd313f into sendwithus:main Mar 18, 2024
1 check failed
@demoore
Copy link
Member

demoore commented Mar 18, 2024

Merged! 🚀 Thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants