Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix link checker comment on PR workflow #317

Conversation

zevisert
Copy link
Contributor

Fiddling around a bit more with GHA, sorry for the noise! It's a little difficult to contribute this kind of workflow without being an owner on this repo since the tokens granted to PRs from forks don't include permissions to write comments on forks. I've now confirmed this workflow's functionality on our fork, and I think it should work fine here now too. I'm going to close #316 one more time and wait for this to land before trying once more there.

I hope this is correct now, at least I have evidence of it working on our fork: revela-systems#7 (comment)

@zevisert
Copy link
Contributor Author

@demoore can you take a look at this? Non members can't add assignees / reviewers

@demoore
Copy link
Member

demoore commented Jun 14, 2024

oh hey, this looks like it's working great. Thanks, @zevisert !

@demoore demoore merged commit 46c52c1 into sendwithus:main Jun 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants