Crud #6
Open
Crud #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuwy
approved these changes
Oct 17, 2020
|
|
||
| trait App { | ||
| def greet(request: GreetRequest): GreetResponse | ||
| // reply on requested value with the same value |
There was a problem hiding this comment.
Упоминал в прошлом ДЗ что лучше использовать ScalaDoc формат комментариев.
There was a problem hiding this comment.
Да, я делал его до проверки прошлого ДЗ, поэтому все еще так :))
Видимо я недопонял как именно нужно было сделать, со слов преподавателя мне казалось как сделайте PR на код из моего репозитория. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented CRUD for most operations
Implemented collections instead of static bindings
Config moved from App to separate Engine