Changes required for parallel build jobs #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Kolberg <[email protected]>
echlebek
requested changes
Jun 16, 2020
|
@echlebek This code is already being used in CI so I'll open an issue to write tests and add this repository to CircleCI. I'll implement the other two suggestions now. |
|
I think it's really important that this code can be maintained. I'd prefer if tests were added before accepting this PR even if CI isn't set up, as these types of things tend to languish. Could you add even a smoke test? +1 on filing an issue for CI setup though. CC @portertech, we may want to add this repository to the zenhub board. |
Signed-off-by: Justin Kolberg <[email protected]>
|
CI issue: #25 |
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
|
@echlebek added - and they even found an issue! |
Signed-off-by: Justin Kolberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Kolberg [email protected]