Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP Authentication #346

Open
wants to merge 79 commits into
base: master
Choose a base branch
from
Open

Conversation

betapictoris
Copy link
Contributor

@betapictoris betapictoris commented Aug 6, 2023

Limitations

  • Currently the bind user's password is stored unencrypted, this is a limitation of LDAP.

Fixes: #44.

@betapictoris betapictoris changed the title [WIP] LDAP Authentication LDAP Authentication Aug 6, 2023
@sentriz sentriz modified the milestone: v0.16.0 Aug 31, 2023
@sentriz
Copy link
Owner

sentriz commented Sep 7, 2023

thanks for the effort here 👍

it also may take some time for me to review since i don't know anything about LDAP. and i don't think i should blindy accept something i don't know about (no offense 😁) i will do some reading or get a second pair of eyeballs on it

there seems to be some lint errors btw

@sentriz
Copy link
Owner

sentriz commented Mar 5, 2024

there is some more discussion here opensubsonic/open-subsonic-api#25

@betapictoris
Copy link
Contributor Author

to my knowledge, storing is plaintext is a requirement from the subsonic protocol. this is to check credentials using the salt+token method

Sorry for the late response, but I hadn't thought of that, thanks for letting me know.

@betapictoris
Copy link
Contributor Author

You can implement a server-side auth caching method.

@nitnelave, this has been done in fccf016.

Copy link
Owner

@sentriz sentriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi there seems like there some lint errors

cmd/gonic/gonic.go Outdated Show resolved Hide resolved
@sentriz sentriz force-pushed the master branch 3 times, most recently from c5b3a1c to 86fd590 Compare May 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

external user authentification
4 participants