Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I've added support for lyrics.
When we make a scan now we check for lyrics inside the file using
taglib
, once the scan process in finished we have all lyrics saved on the db so we can retrieve them faster. When we are looking for a lyrics it first checks if there is a embedded lyric, if there is we return that, otherwise it looks for a fileSONG_NAME.lrc
and reads the lyrics from it. If there isn't a.lrc
file an empty response is provided.I've added support for both
getLyrics
andgetLyricsBySongId
methods. I have even created a migration, but i'm not so sure if that works fine maybe give that a double check.Let me know if there is something to change.
P.S. I have used some code from #488