Throttling on arbitrary resources. #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| -- Throttle apis | ||
| QlessAPI['throttle.set'] = function(now, tid, max, ...) | ||
| local expiration = unpack(arg) |
There was a problem hiding this comment.
Why deal with ... and unpack(arg), rather than declaring expiration as an argument?
There was a problem hiding this comment.
it was to make it an optional argument, not terrible strong in lua.
Merge upstream
retry pop up to config limit when pop quantity would be unfulfilled d…
Release jobs from throttle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements throttling for arbitrary resources.
#27
Currently running in our production system with 14k worker processes spread across 15 redis processes.
Created a throttle object model in qless-core which consists of a active job set, a pending job set, and a maximum value. The throttle controls how many jobs that can run simultaneously.
Modified the put command to attempt to throttle new jobs. This is to prevent wasting pops to move jobs into the throttled state.
Modified the pop command to check if all the throttles for the job are available and if not to add it to pending queue for one of the throttles.
Modified the complete, fail, retry commands to release all throttles associated with the job.
When a throttle is released the throttle checks its pending job set and inserts up to (maximum - active) jobs into the waiting queue to be popped.
Let me know of any questions, changes that need to be made etc.