Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against multiple redis versions. #68

Merged
merged 3 commits into from
Mar 3, 2017

Conversation

bkirz
Copy link
Contributor

@bkirz bkirz commented Mar 3, 2017

This way, we can better address problems like #64 that are specific to certain redis versions. Once this is merged, we can rebase #64 on top of it and confirm that it fixes the issue before merging.

Copy link
Contributor

@b4hand b4hand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think this is a necessary step to maintain future redis compatibility. Are you going to go ahead and merge this or will you fix the tests first?

@bkirz
Copy link
Contributor Author

bkirz commented Mar 3, 2017

@b4hand, after talking to @myronmarston about it, I'd like to:

How's that sound?

Copy link
Contributor

@b4hand b4hand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@bkirz bkirz merged commit a835721 into master Mar 3, 2017
@bkirz bkirz deleted the bkirz/build-matrix-redis-versions branch March 3, 2017 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants