Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support waiting job pagination #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NathanBaulch
Copy link

I have a scenario where I need to iterate through all waiting jobs in a queue so I can cancel them, but was surprised to find this feature missing. This simple PR adds support for the "waiting" status in the existing pageable jobs API.

Unit test included of course.

@dlecocq
Copy link

dlecocq commented May 21, 2019

Looks good to me, though I lack merge powers.

@NathanBaulch
Copy link
Author

Bump!

@b4hand
Copy link
Contributor

b4hand commented Sep 13, 2022

@NathanBaulch Unfortunately, I think all of the folks who formerly worked on qless at Moz (seomoz GitHub org) no longer work there, and it seems like the company has revoked permissions for non-employees that were working on the various open source projects. I've tried to contact various employees that are still at the company but none seem interested or able to grant permissions externally. So I would consider these projects to be abandoned. If someone wants to revive qless, I imagine you'll need to start a separate fork, and probably not using the GitHub fork mechanism as that will force PRs to be merged into this upstream repo which is a dead end at this point in time. I too have tried merging PRs, but can no longer do so.

@NathanBaulch
Copy link
Author

Ah, shame. Thanks for the inside info @b4hand !

@UncleMatty
Copy link

Worth noting that for those of us who were at Moz from 2018-2020, qless had become a bit of an anti pattern anyway.

If you really need help with this, I might be able to track someone down.

@NathanBaulch
Copy link
Author

Interesting... qless was being abused somehow? Or requirements/scale grew beyond it's capabilities?
Any nuggets of wisdom to share from the trenches @UncleMatty?

@UncleMatty
Copy link

Nothing particularly insightful. Using qless to manage a job queue may have been creative and clever at one point, but it outgrew its usefulness, particularly with the emergence of lighter weight and easier to manage tools like Kafka, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants