Point to new rep-cpp, which points to new url-cpp, fixing <limits> #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A case of not including what we use - relying on other headers to include what intend to include, when what they include should be considered opaque, to us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A case of not including what we use - relying on other headers to include what intend to include, when what they include should be considered opaque, to us.
This is driven by the error found in: #132 although it does not fully address it (and especially not the other host of issues on this project). However, it does at least move us in the right direction. Given internal discussion, the scope of the changes, and the current state of the project, going to go ahead and merge this to minimize time commitment here.