Move #expires, #expired, and #ttl to ExpiringObject class. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlecocq
approved these changes
Jun 6, 2018
| @@ -83,9 +102,17 @@ def allowed(self, url, agent): | |||
|
|
|||
| def fetch(self, url): | |||
| '''Return (expiration, Robots) for the robots.txt at the provided URL.''' | |||
| expires = [0] | |||
There was a problem hiding this comment.
It's been a while since I've done python. Is this part of that weird closure thing? As in, it has to be an array for us to be able to save a value in this scope from check_ttl_hook?
There was a problem hiding this comment.
Yes, that's correct. We need a mutable object to modify in the closure. A bare assignment will create a new local variable rather than modify the variable in the outer scope.
| robots = Robots.fetch( | ||
| url, ttl_policy=self.ttl_policy, *self.args, **self.kwargs) | ||
| return (robots.expires, robots) | ||
| url, after_response_hook=check_ttl_hook, *self.args, **self.kwargs) |
There was a problem hiding this comment.
I agree that this doesn't feel great, but I don't see any reason not to trust it. We could also have a method off of Robots that returns a pair of (response, obj), but I think this is fine as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially in response to some of the confusion around #86.
I think this is technically a little cleaner from an object oriented analysis standpoint. However, relying on the
after_response_hookand the mechanism that I used to set the expires seems a little hacky to me.I'm curious what others think about this or if there's a better solution. Also, there's definitely some docs in the README that will need to be updated before merging this.
@dlecocq: I'm interested in your thoughts since you looked at the prior issue as well.