Exit bug #102
Merged
Exit bug #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #102 +/- ##
==========================================
- Coverage 96.57% 96.14% -0.43%
==========================================
Files 2 2
Lines 204 207 +3
Branches 24 25 +1
==========================================
+ Hits 197 199 +2
Misses 5 5
- Partials 2 3 +1 ☔ View full report in Codecov by Sentry. |
sadrasabouri
requested changes
Sep 23, 2024
sadrasabouri
requested changes
Sep 24, 2024
Comment on lines
+75
to
+78
| >>> get_input_standard(test_keyboard_interrupt) | ||
| Traceback (most recent call last): | ||
| ... | ||
| SystemExit |
There was a problem hiding this comment.
Can we also have EXIT_MESSAGE content here?
That's not a big deal, just to make sure everything is tested as much as possible.
There was a problem hiding this comment.
Rather than that, it's good. If you don't think adding such a thing is necessary you can merge it.
There was a problem hiding this comment.
Test system behavior is a bit weird here. I think it's because of the sys.exit().
sadrasabouri
approved these changes
Sep 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?