Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/clean screen function #98

Merged

Conversation

oscarArismendi
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This pull request integrates the clear_screen function into the main module (__main__.py). Specifically, the function is called when the reset mode is activated. This enhancement ensures that the console screen is cleared appropriately, providing a cleaner interface during reset operations.

Any other comments?

For additional context, you can view the related GIF below:

- Added doctest for clear_screen function to verify it runs without errors.
- Develop clear_screen function to clear the console screen.
- Updated __main__.py to call clear_screen function when reset mode activated
@oscarArismendi
Copy link
Contributor Author

I noticed the os.system usage in the code. If necessary, I can update it to use the subprocess module to address the security concern. Just let me know if you’d like me to make this change.

@sepandhaghighi sepandhaghighi added the enhancement New feature or request label Aug 31, 2024
@sepandhaghighi sepandhaghighi added this to the nafas v0.8 milestone Aug 31, 2024
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.54%. Comparing base (ebcfc97) to head (87c484b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
nafas/functions.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #98      +/-   ##
==========================================
- Coverage   97.47%   96.54%   -0.92%     
==========================================
  Files           2        2              
  Lines         197      202       +5     
  Branches       22       23       +1     
==========================================
+ Hits          192      195       +3     
- Misses          4        5       +1     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@sepandhaghighi sepandhaghighi merged commit c7c0032 into sepandhaghighi:dev Aug 31, 2024
24 checks passed
@sepandhaghighi
Copy link
Owner

@oscarArismendi Thanks for your contribution 🚀

@oscarArismendi oscarArismendi deleted the feature/clean_screen_function branch September 2, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants