Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.8 #481

Merged
merged 13 commits into from
Feb 1, 2023
Merged

Version 3.8 #481

merged 13 commits into from
Feb 1, 2023

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

#349 #350

What does this implement/fix? Explain your changes.

Version 3.8

Any other comments?

dependabot bot and others added 12 commits December 19, 2022 13:48
Bumps [numpy](https://github.com/numpy/numpy) from 1.23.5 to 1.24.0.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.23.5...v1.24.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix : Codacy error (unused variable) fixed.

* fix : docstring `Curve.__init__` fixed.

* update : `README.md` updated.

* update : document updated (`sample_weight`).

* fix : minor edits in `README.md`.
* fix : doc_run.bat updated

* fix : doc_to_html.bat updated

* doc : CHANGELOG updated
* feat : distance method added #349 #350

* doc : minor edit in docstring

* fix : minor edit in distance method error handler

* edit : minor pep8 edits.

* add : `BatageljBren` metric added.

* add : `BaulieuI` metric added.

* add : `BaulieuII` metric added.

* add : `BaulieuIII` metric added.

* add : `BaulieuIV` metric added.

* add : `BaulieuV` metric added.

* add : `BaulieuVI` metric added.

* add : `BaulieuVII` metric added.

* add : `BaulieuVIII` metric added.

* add : `BaulieuIX` metric added.

* add : `BaulieuX` metric.

* add : `BaulieuXI` metric.

* add : `BaulieuXII` metric.

* add : `BaulieuXIII` metric.

* add : `BaulieuXIV` metric.

* add : `BaulieuXV` metric.

* add : `BeniniI` metric.

* add : `BeniniII` metric.

* add : `Canberra` metric.

* add : `Clement` metric.

* add : `ConsonniTodeschiniI` metric.

* add : `ConsonniTodeschiniII` metric.

* add : `ConsonniTodeschiniIII` metric.

* add : `ConsonniTodeschiniIV` metric.

* add : `ConsonniTodeschiniV` metric.

* doc : Distance.ipynb added

* fix : __init__.py updated

* reformat refs #349 #350

* Add Abydos ref #349 #350

* doc : Distance.ipynb updated

* fix : verified_test.py updated

* fix : error_test.py updated

* fix : function_test.py updated

* doc : Document.ipynb updated

* fix : autopep8

* doc : CHANGELOG updated

* doc : Document updated

* doc : minor edit in Distance.ipynb titles

* doc : Baulieu IV formula fixed

* doc : Distance notebook added to notebook_check.py

* doc : distance method docstring updated

* doc : verified_test.py links updated

* doc : minor edit in Distance.ipynb style

Co-authored-by: sadrasabouri <[email protected]>
Co-authored-by: alirezazolanvari <[email protected]>
Bumps [numpy](https://github.com/numpy/numpy) from 1.24.0 to 1.24.1.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.24.0...v1.24.1)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add : `__contains__` method added.

* change : `__contains__` method place changed.

* add : `__getitem__` method added.

* fix : docstring fixed.

* edit : `__getitem__` functionality edited.

* update : docstring updated.

* fix : minor issue fixed.

* doc : minor edit in getitem and contains methods docstring

* doc : Document updated

* doc : minor edit in getitem and contains methods docstring

* doc : minor edit in getitem and contains methods docstring

* doc : minor edit in getitem and contains methods docstring

* doc : minor edit in getitem and contains methods docstring

* doc : minor edit in getitem method docstring

Co-authored-by: sepandhaghighi <[email protected]>
* fix : minor edit in position method test

* fix : minor edit in compare test

* fix : minor edit in online_help function test

* doc : CHANGELOG updated
* Add lambda interpretation function

* Add Krippendorff’s alpha interpretation function

* Add Pearson's C inerpretation function

* minor edits in docstrings

* Add kappa benchmark list

* Change default overall bechmark weight

* Add new benchmarks params

* Add new benchmarks to overall stats

* Add sort function

* Change sort method

* fix minor bug in lambda analysis func

* Change compare results based on the new added overall benchmarks

* Change output reports based on the new added overall benchmarks

* Change overall stats based on the new added overall benchmarks

* Add dunc test for the new overal benchmarks

* Minor edits on test results

* Add the new overall benchmarks results to the tests

* Add new overall benchmarks

* Minor edits

* Fix minor bug in sort function

* Minor edit in Document

* Fix minor edit in sort docstring

* Resolve some PR comments

* doc : Document updated #479

* doc : Compare section in Document updated #479

* doc : Compare example updated

* doc : CHANGELOG updated

---------

Co-authored-by: sepandhaghighi <[email protected]>
* fix : `relabel` method bug fixed.

* log : changes logged.

* test : tests added.

* change : keeping the original class order.
@sepandhaghighi
Copy link
Owner Author

@alirezazolanvari @sadrasabouri Hi folks
Please complete this review by Wednesday- 2023-02-01 - 11:59 AM GMT+3:30
Notice: Only review, don't need to merge

- `relabel` method sort bug fixed
- `README.md` modified
- Document modified
- Test system modified
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we mention the changes in compare overall benchmarks and overall benchmarks weights?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right!

  • Compare overall benchmarks default weights updated

Good?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in f2c225a

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #481 (f2c225a) into master (1760e37) will increase coverage by 0.16%.
The diff coverage is 99.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   99.13%   99.28%   +0.16%     
==========================================
  Files          12       13       +1     
  Lines        2629     2913     +284     
  Branches      430      447      +17     
==========================================
+ Hits         2606     2892     +286     
+ Misses          9        8       -1     
+ Partials       14       13       -1     
Impacted Files Coverage Δ
pycm/pycm_interpret.py 98.82% <94.29%> (-1.18%) ⬇️
pycm/pycm_compare.py 100.00% <100.00%> (+0.85%) ⬆️
pycm/pycm_curve.py 97.03% <100.00%> (ø)
pycm/pycm_distance.py 100.00% <100.00%> (ø)
pycm/pycm_handler.py 100.00% <100.00%> (ø)
pycm/pycm_obj.py 98.88% <100.00%> (+0.27%) ⬆️
pycm/pycm_output.py 96.94% <100.00%> (+0.74%) ⬆️
pycm/pycm_overall_func.py 100.00% <100.00%> (ø)
pycm/pycm_param.py 100.00% <100.00%> (ø)
pycm/pycm_util.py 99.69% <100.00%> (+0.01%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sepandhaghighi sepandhaghighi merged commit be1d8e2 into master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants