-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messages unification #552
Messages unification #552
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #552 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 14 14
Lines 3097 3097
Branches 467 467
=======================================
Hits 3087 3087
Misses 4 4
Partials 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome back buddy. Thanks for your efforts. I left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alirezazolanvari Thanks for your efforts 💯
Please take a look at my comments 🔥
@alirezazolanvari Just a friendly reminder ⏲️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alirezazolanvari Take a look at my comment 🔥
@alirezazolanvari Just a friendly reminder ⌛ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@sadrasabouri Please re-review 🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this implement/fix? Explain your changes.
Modify error and warning messages.