Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages unification #552

Merged
merged 18 commits into from
Sep 19, 2024
Merged

Messages unification #552

merged 18 commits into from
Sep 19, 2024

Conversation

alirezazolanvari
Copy link
Collaborator

What does this implement/fix? Explain your changes.

Modify error and warning messages.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (fe59e9c) to head (5d234c7).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #552   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          14       14           
  Lines        3097     3097           
  Branches      467      467           
=======================================
  Hits         3087     3087           
  Misses          4        4           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back buddy. Thanks for your efforts. I left some comments.

CHANGELOG.md Outdated Show resolved Hide resolved
Test/error_test.py Show resolved Hide resolved
pycm/pycm_param.py Outdated Show resolved Hide resolved
pycm/pycm_param.py Outdated Show resolved Hide resolved
@sepandhaghighi sepandhaghighi added this to the PYCM 4.1 milestone Aug 21, 2024
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alirezazolanvari Thanks for your efforts 💯
Please take a look at my comments 🔥

CHANGELOG.md Outdated Show resolved Hide resolved
Test/error_test.py Outdated Show resolved Hide resolved
Test/error_test.py Outdated Show resolved Hide resolved
Test/error_test.py Outdated Show resolved Hide resolved
pycm/pycm_param.py Outdated Show resolved Hide resolved
pycm/pycm_param.py Outdated Show resolved Hide resolved
pycm/pycm_param.py Outdated Show resolved Hide resolved
pycm/pycm_param.py Outdated Show resolved Hide resolved
pycm/pycm_param.py Outdated Show resolved Hide resolved
@sepandhaghighi
Copy link
Owner

@alirezazolanvari Just a friendly reminder ⏲️

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alirezazolanvari Take a look at my comment 🔥

pycm/pycm_param.py Outdated Show resolved Hide resolved
@sepandhaghighi
Copy link
Owner

@alirezazolanvari Just a friendly reminder ⌛

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sepandhaghighi
Copy link
Owner

@sadrasabouri Please re-review 🔥
If everything is okay, Squash/Merge it after approval 🚀

Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadrasabouri sadrasabouri merged commit 2ddaaf3 into dev Sep 19, 2024
45 checks passed
@sadrasabouri sadrasabouri deleted the messages-unification branch September 19, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants