Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measurement fix by @endryha (issue #1) #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Measurement fix by @endryha (issue #1) #4

wants to merge 1 commit into from

Conversation

almozavr
Copy link

Prevents notifyDataSetChanged problems.

@sephiroth74
Copy link
Owner

Thanks but I pushed a new version just yesterday which doesn't use the mChildHeight anymore, because now children can have a variable height too.
Can you pls check your patch against this new version?

@almozavr
Copy link
Author

Just checked out latest version (cf17201)
It acts incorrectly: height takes all the space available like it is match_parent but it's not.

@sephiroth74
Copy link
Owner

you should pass a fixed layout_height, otherwise we need to check all the children heights, since they can have a variable height.

@almozavr
Copy link
Author

I know, you are talking about: http://stackoverflow.com/a/11295287/691993
But, it would be lovely to have an option to use wrap_content since it's not alway obvious which height to use and have to sacrifice some performance due to calculations. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants