Skip to content

Commit

Permalink
Fix bash boolean comparisons
Browse files Browse the repository at this point in the history
  • Loading branch information
sergioisidoro committed Feb 27, 2020
1 parent 69e904b commit 561fa86
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ variable to false, because it is defined in the defaults
- name: "Run action"
env: # Or as an environment variable
TX_TOKEN: ${{ secrets.TX_TOKEN }}
PUSH_SOURCES: "True"
PUSH_TRANSLATIONS: "True"
PULL_SOURCES: "False"
PULL_TRANSLATIONS: "True"
PUSH_SOURCES: "true"
PUSH_TRANSLATIONS: "true"
PULL_SOURCES: "false"
PULL_TRANSLATIONS: "true"
```
### Docker image
Expand Down
8 changes: 4 additions & 4 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ runs:
using: 'docker'
image: 'docker://sergioisidoro/github-transifex-action'
env:
PUSH_SOURCES: "True"
PUSH_TRANSLATIONS: "False"
PULL_SOURCES: "False"
PULL_TRANSLATIONS: "False"
PUSH_SOURCES: "true"
PUSH_TRANSLATIONS: "false"
PULL_SOURCES: "false"
PULL_TRANSLATIONS: "false"

8 changes: 4 additions & 4 deletions entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,22 @@

echo $config > ~/.transifexrc

if $PUSH_SOURCES; then
if [ "$PUSH_SOURCES" = true ] ; then
echo "PUSHING SOURCES"
tx push -s
fi

if $PUSH_TRANSLATIONS; then
if [ "$PUSH_TRANSLATIONS" = true ] ; then
echo "PUSHING TRANSLATIONS"
tx push -t
fi

if $PULL_SOURCES; then
if [ "$PULL_SOURCES" = true ] ; then
echo "PULLING SOURCES"
tx pull -s
fi

if $PULL_TRANSLATIONS; then
if [ $PULL_TRANSLATIONS = true ] ; then

This comment has been minimized.

Copy link
@Gustry

Gustry Feb 28, 2020

Is-it normal the missing " " on this line?

This comment has been minimized.

Copy link
@sergioisidoro

sergioisidoro Feb 28, 2020

Owner

Nope, good point ! I'll fix this asap.

echo "PULLING TRANSLATIONS"
tx pull -a
fi

0 comments on commit 561fa86

Please sign in to comment.