Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: udpate node-pre-gyp params host & remote_path for v5x #1061

Merged

Conversation

thom-nic
Copy link
Contributor

to support overriding a host mirror for prebuilt downloads.

Fixes #1055

to support overriding a host mirror for prebuilt downloads.

Fixes serialport#1055
@thom-nic
Copy link
Contributor Author

thom-nic commented Jan 10, 2017

This should look identical to the v4x PR #1060

@codecov-io
Copy link

Current coverage is 90.95% (diff: 100%)

Merging #1061 into master will increase coverage by 1.54%

@@             master      #1061   diff @@
==========================================
  Files            14         13     -1   
  Lines           736        652    -84   
  Methods          83         74     -9   
  Messages          0          0          
  Branches        180        155    -25   
==========================================
- Hits            658        593    -65   
+ Misses           78         59    -19   
  Partials          0          0          

Powered by Codecov. Last update e588e88...1707b02

@reconbot reconbot merged commit d170eab into serialport:master Jan 11, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jul 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants