Ability to delete log files and recreate them immediately #144
Conversation
| @@ -72,7 +72,7 @@ public SharedFileSink(string path, ITextFormatter textFormatter, long? fileSizeL | |||
| path, | |||
| FileMode.Append, | |||
| FileSystemRights.AppendData, | |||
| FileShare.ReadWrite, | |||
| FileShare.ReadWrite | FileShare.Delete, | |||
There was a problem hiding this comment.
File deletion was enabled by adding this, but I don't know if it's the best way to do this.
Should we make another config entry to only enable deletion when required?
| TextWriter _output; | ||
| FileStream _underlyingStream; | ||
| readonly string _path; |
There was a problem hiding this comment.
I needed to make _output and _underlyingStream non-readonly, so I could dispose them and recreate the file after it was deleted.
Also added _path variable to be re-used when recreating the file.
| if (!System.IO.File.Exists(_path)) | ||
| { | ||
| _underlyingStream.Dispose(); | ||
| _underlyingStream = System.IO.File.Open(_path, FileMode.Append, FileAccess.Write, FileShare.ReadWrite | FileShare.Delete); | ||
| _output = new StreamWriter(_underlyingStream, new UTF8Encoding(encoderShouldEmitUTF8Identifier: false)); | ||
| } |
There was a problem hiding this comment.
Although I'm worried about the performance of this File.Exists(), this was how I managed to make the file be re-created. If you guys have another idea of how to make this verification, please let me know.
I also noticed that this chunk must be before _underlyingStream.Seek(0, SeekOrigin.End); in order to create the file correctly after is deleted.
|
I noticed that the tests are not passing with VS2019 image. I'm going to check this as soon as I can. |
|
@thiagosgarcia @nblumhardt Any update on this issue? Do you need help? |
|
Hey! I'm sorry, I've been busy these last months and completely forgot about this. |
|
That's great to hear. I'm willing to help out where I can, but I'm new to the Serilog codebase so I can't promise anything but time and goodwill. 😉 |
|
Hey all! Looks like this PR has stalled; #186 might offer a partial solution as long as you're not using the Doing some housekeeping and clearing out the list of open PRs to keep things manageable; if you do decide to pick it back up, @thiagosgarcia, please just let me know and we can reopen 👍 |
|
This is a much needed feature. Can someone fix this issue and merge the PR after testing? |
As discussed in #96 and #128, this gives the ability to delete files when is created by a SharedFileSink and recreates the rolling file when deleted.
Please, note that this is still a initial version for the solution, I'm going to implement more tests and eliminate some duplication.
I'd like to start this discussion in order gather some insights from the project maintainers and address some questions I have. I'm gonna give some more thoughts on this one as soon as I can.
Allow Log File to be Deleted at Runtime #96
I was able to make this work by just adding
FileShare.Deleteat bothFileStreaminstances. This would make all shared files 'deleteable'.About that:
canDeleteFiles: true)Recreate current rolling file immediately to log on file deleting #128
This was a little more tricky, but I was able to make this work using
SharedFileSink.OSMutexQuestions I have:
SharedFileSink.AtomicAppend? I wasn't able to run this class in my tests or by debugging.File.Exists()atSharedFileSink.OSMutex.csline 85? Do you guys have a better idea to make this check? This was actually how I managed to make the file be re-created right after deletion.