Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db-migrations): update content of every entity_revision to new Editor format #1865

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

hejtful
Copy link
Contributor

@hejtful hejtful commented Feb 4, 2025

Linear: EDTR-98
Frontend PR: serlo/frontend#4465

Note: Because the new metadata has non-deterministic values, such as dateModified and id, only test for matching document content.

@LarsTheGlidingSquirrel
Copy link
Member

Once this ran in staging could you send us an example of the resulting state to verify that everything looks right?

@hejtful
Copy link
Contributor Author

hejtful commented Feb 5, 2025

@LarsTheGlidingSquirrel Thanks for the review, fixed the version!

Could you please explain what you mean by "resulting state"? The content column of a random entity_revision row? Or the state that the Editor receives from the frontend? Or something else? Just as a note, frontend changes will be prepared, and merged to staging just after this migration is run on staging.
Also, what do you mean by "send us"? Do you want me to post it here as a comment or?

@LarsTheGlidingSquirrel
Copy link
Member

The content column of a random entity_revision row?

This is what I had in mind. I don't understand how migrations work very well so I can't really check the code. But I can definitely check if the resulting state looks fine.

Do you want me to post it here as a comment or?

No preference. Any way you see fit ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants