chore: simulate cross-origin iframe in editor demo page #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @serlo/frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
Could you give a simple example of something that works same-origin but would fail with the new setup (for testing)? |
The interactive video worked fine in same-origin, but got stuck in loading for cross-origin. Maybe that is easy to test.
|
chore(editor-dev): simulate cross origin with one dev server
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The editor preview page is wrapped in an iframe where the embed using a subdomain. This simulates the cross-origin iframe embedding we have in the LTI integrations.
With this, we can quickly check if editor code changes also work in the LTI world. Also, we can quickly test iframe security attributes like
sandboxandallow.Unexpectedly, hot reload still works even though we are in an iframe. 🥳
However, the state is not added to the browser address bar.