[#518] Update rollup binaries #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PruStephan
force-pushed
the
PruStephan/#518-package-smart-contract-rollup
branch
from
d8f8d9f to
5aae691
Compare
|
I think it worth to reword commit message and pr, because it's not about removing |
|
There is also mentions |
krendelhoff2
requested changes
Oct 25, 2023
DMozhevitin
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Agree with comments from @krendelhoff2 and have no other ones
PruStephan
force-pushed
the
PruStephan/#518-package-smart-contract-rollup
branch
from
a05c669 to
eacf5b4
Compare
krendelhoff2
requested changes
Nov 3, 2023
PruStephan
force-pushed
the
PruStephan/#518-package-smart-contract-rollup
branch
from
eacf5b4 to
bd70eb7
Compare
PruStephan
force-pushed
the
PruStephan/#518-package-smart-contract-rollup
branch
4 times, most recently
from
a080a42 to
2c4baae
Compare
krendelhoff2
changed the title
krendelhoff2
force-pushed
the
PruStephan/#518-package-smart-contract-rollup
branch
from
2c4baae to
f4f728f
Compare
DMozhevitin
approved these changes
Nov 23, 2023
Problem: Despite that transaction rollup was depricated, we still have a lot of mentions of it in our repo. Solution: Remove all mentions of transaction rollup binaries.
Problem: Since last take on it, rollup binaries were changed a lot in interface. Solution: Update it accordingly.
krendelhoff2
force-pushed
the
PruStephan/#518-package-smart-contract-rollup
branch
from
f4f728f to
00aee93
Compare
krendelhoff2
approved these changes
Nov 24, 2023
krendelhoff2
deleted the
PruStephan/#518-package-smart-contract-rollup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the usage of smart-rollup binaries so that instead of transaction rollup binaries we use smart rollup binaries
Related issue(s)
Resolves #
Related changes (conditional)
I checked whether I should update the README
I checked whether native packaging works, i.e. native binary packages
can be successfully built.
Stylistic guide (mandatory)