Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KSP from kotest-property extension #246

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

serpro69
Copy link
Owner

Removes a dependency on KSP (and a bunch of code with that), as suggested by @CLOVIS on kotlinlang slack and makes things much simpler both from code perspective and usability perspective.

I did like playing around with KSP, but I like removing code even more 😁

@serpro69 serpro69 added enhancement 🚀 New feature or request extension 🏗️ Issue related to :extension modules breaking 💔 Indicates a breaking change labels Aug 13, 2024
@serpro69 serpro69 force-pushed the refactor_kotest_ext branch from d7a0145 to f8fbfa9 Compare August 13, 2024 16:15
@CLOVIS-AI
Copy link

Sorry for finding a simpler way 😅 I too love removing code!

@serpro69 serpro69 merged commit d3e60c7 into master Aug 13, 2024
4 checks passed
@serpro69 serpro69 deleted the refactor_kotest_ext branch August 13, 2024 19:13
@serpro69 serpro69 mentioned this pull request Aug 13, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking 💔 Indicates a breaking change enhancement 🚀 New feature or request extension 🏗️ Issue related to :extension modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants